This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use default or custom provider chain for s3 authentication #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeqo Any chance you or one of your team could review and verify you are happy with my solutions to the 2 outstanding comments on the previous pull request this one replaces? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #227 which was originally implemented by @steephengeorge.
Most of the hard work was already done by @steephengeorge and this PR is a duplicate that addresses the last few code review comments left by @jeqo.
@jeqo I'd appreciate it if you could review this PR to ensure you are happy as i'd like to get this wrapped up and in.
The changes I added here were:
String.formatissue you identified.AwsCredentialProviderFactory(the primary change in the original PR that had no tests)