Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive object analysis (fix #118) #119

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Conversation

hugoattal
Copy link
Collaborator

Fix #118

Description

It's a very simple check to avoid tree-walking recursive objects. We could do a bit better (like stopping when it references something that has already been walked), but I'm not sure if it's worth the trouble...


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal self-assigned this Jun 5, 2022
@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 95e0d3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/629d2017c542c80008d7bf25
😎 Deploy Preview https://deploy-preview-119--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 95e0d3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/629d201795141c000886e5eb
😎 Deploy Preview https://deploy-preview-119--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 95e0d3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/629d2017892d1d000846bc9a
😎 Deploy Preview https://deploy-preview-119--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal hugoattal added the bug Something isn't working label Jun 5, 2022
@hugoattal hugoattal requested a review from Akryum June 5, 2022 20:09
@hugoattal
Copy link
Collaborator Author

@Akryum

I think we can check for already visited objects quite easily with a Set:

Yes, that's what I though, but I was not sure if it was actually useful. I'll do that then!

@hugoattal
Copy link
Collaborator Author

Done here 95e0d3b

@Akryum Akryum changed the title fix: fix recursive object analysis (fix #118) fix: recursive object analysis (fix #118) Jun 6, 2022
@Akryum Akryum merged commit 88ecbbf into main Jun 6, 2022
@Akryum Akryum deleted the fix-recursive-object branch June 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much recursion error for self referencing object in props
2 participants