Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dark mode (fix #2) #12

Merged
merged 2 commits into from
Feb 4, 2022
Merged

feat: Add dark mode (fix #2) #12

merged 2 commits into from
Feb 4, 2022

Conversation

hugoattal
Copy link
Collaborator

Fix #2

Description

I added dark mode in a header using vue-use:
image

Additional context

It's the first time I use tailwind, and as someone who love doing frontend stuff, I can't emphasize enough how much I hated it. IMO, this enforces all the bad practice on frontend development without any benefit (other that not using CSS? I mean, I love CSS, so it's not a benefit to me).

  • The templates classes are unreadable
  • I must search the documentation every time I want to use a CSS property
  • No class name makes sense, especially when using flex
  • No fine-tuning at all
  • I hoped that making a dark theme will be as easy as adding a class in the HTML, but no, we must update ALL the component to add a dark: class instead of leveraging the use of CSS vars.
  • The result isn't even that good

I know you guys are used to it, so I'd just want to know if its usage is still subject to discussion or if it's definitive.
I'd totally get it if you want to stick with it, but I must say I won't do much frontend using it.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the enhancement New feature or request label Feb 4, 2022
@hugoattal hugoattal self-assigned this Feb 4, 2022
@netlify
Copy link

netlify bot commented Feb 4, 2022

❌ Deploy Preview for histoirejs failed.

🔨 Explore the source changes: 4af1c55

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoirejs/deploys/61fd64ee4520920007983391

@hugoattal hugoattal requested a review from Akryum February 4, 2022 12:26
@@ -45,9 +45,11 @@
"sade": "^1.8.1",
"vite": "^2.7.13",
"vue": "^3.2.27",
"vue-router": "^4.0.0"
"vue-router": "^4.0.0",
"vue-use": "^0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package is @vueuse/core and is already installed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah, nice spot! I'll update this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: 4af1c55

@hugoattal hugoattal requested a review from Akryum February 4, 2022 17:40
@Akryum Akryum merged commit b6535b1 into main Feb 4, 2022
@Akryum Akryum deleted the feat-dark-mode branch February 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dark mode
2 participants