Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Build Failes with Vite Legacy #156

Closed
6 tasks done
CalebKester opened this issue Jun 28, 2022 · 1 comment
Closed
6 tasks done

Library Build Failes with Vite Legacy #156

CalebKester opened this issue Jun 28, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@CalebKester
Copy link

CalebKester commented Jun 28, 2022

Describe the bug

We have both histoire and vite plugin legacy on our project. We had build errors recently with the histoire build process
image

Disabling vite legacy solved this issue.

image

I can build an example repo for this but is there anyway we can disable the legacy plugin only when histoire builds?

Reproduction

https://stackblitz.com/edit/histoire-vue3-starter-hh1oyb?file=vite.config.ts

Install Vite Legacy in any project to see this.

System Info

System:
    OS: Windows 10 10.0.22000
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz
    Memory: 15.07 GB / 31.84 GB
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (103.0.1264.37)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    @vitejs/plugin-legacy: ^1.8.2 => 1.8.2
    @vitejs/plugin-vue: ^2.3.0 => 2.3.0
    histoire: ^0.7.8 => 0.7.8
    vite: ^2.9.0 => 2.9.0

Used Package Manager

pnpm

Validations

@CalebKester CalebKester added the to triage This issue needs to be triaged label Jun 28, 2022
@CalebKester
Copy link
Author

Updated with a reproduction link

@Akryum Akryum added bug Something isn't working and removed to triage This issue needs to be triaged labels Jul 21, 2022
@Akryum Akryum self-assigned this Jul 21, 2022
@Akryum Akryum closed this as completed in f057330 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants