Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for the histoire vite server #25

Closed
hugoattal opened this issue Feb 16, 2022 · 1 comment
Closed

Add config for the histoire vite server #25

hugoattal opened this issue Feb 16, 2022 · 1 comment
Assignees
@Akryum
Labels
enhancement New feature or request good first issue Good for newcomers ready to be implemented Design is done and implementation can be done in a PR

Comments

@hugoattal
Copy link
Collaborator

I believe we should add a server option to histoire config, that would be use by the histoire vite server, mainly for specifying a custom port (but maybe there could be other use for it).
@hugoattal hugoattal added the enhancement New feature or request label Feb 16, 2022
@Akryum Akryum added good first issue Good for newcomers need spec Need Specs, UX or UI design... labels Feb 18, 2022
@Akryum
Copy link
Member

Akryum commented Feb 22, 2022

We probably should allow overriding vite config for histoire with a vite config option.

@Akryum Akryum self-assigned this Feb 22, 2022
@Akryum Akryum added ready to be implemented Design is done and implementation can be done in a PR and removed need spec Need Specs, UX or UI design... labels Feb 22, 2022
@Akryum Akryum closed this as completed in 8dcc6e7 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akryum Akryum

Labels
enhancement New feature or request good first issue Good for newcomers ready to be implemented Design is done and implementation can be done in a PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akryum @hugoattal