Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: screenshot overwritten, use size in filename #299

Merged

Conversation

sor4chi
Copy link
Contributor

@sor4chi sor4chi commented Sep 19, 2022

fixes: #298

Description

resolve user-defined custom presets is working not correct in plugin-screenshot.

Additional context

When the user does not set the preset

  • When the user does not set the
  • When one is set
  • When multiple presets are set
    Check the behavior of them

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit eab5629
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6328cced66c90500085c3aff

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit eab5629
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6328cced02fe4d000843e90a
😎 Deploy Preview https://deploy-preview-299--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit eab5629
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6328cced5e77400008735fd6

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit eab5629
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6328cced3942f1000856cfa8
😎 Deploy Preview https://deploy-preview-299--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sor4chi sor4chi changed the title Feat/fix screenshot overwritten bug fix: screenshot overwritten bug Sep 19, 2022
@Akryum Akryum changed the title fix: screenshot overwritten bug fix: screenshot overwritten, use size in filename Oct 2, 2022
@Akryum Akryum merged commit d50608a into histoire-dev:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If screenshot-plugin's multiple custom-presets are set, the output images will be overwritten.
2 participants