fix: import error on Windows (fix #1) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for histoirejs failed. 🔨 Explore the source changes: 59741a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/histoirejs/deploys/61f9a2773d5cf800078ba079 |
hugoattal
changed the title
|
@Akryum I don't have access to netlify logs, I'm not quite sure why the deployment failed... |
|
Don't look at the netlify build, the doc site is not ready yet |
Akryum
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1
Description
Windows has a hard time with slash and backslash on file paths. I used absolute path and pathe to make sure it uses slash.
Histoire now work flawlessly on Windows 🥳 !
What is the purpose of this pull request?