Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External control for dark mode #388

Closed
4 tasks done
mikael-j-rich opened this issue Dec 5, 2022 · 1 comment · Fixed by #438
Closed
4 tasks done

External control for dark mode #388

mikael-j-rich opened this issue Dec 5, 2022 · 1 comment · Fixed by #438
Labels
enhancement New feature or request

Comments

@mikael-j-rich
Copy link

Clear and concise description of the problem

Today the dark mode feature uses useDark from vueuse and this is not configurable externally.

I would like the possibility to either turn off the dark mode feature or force light mode on initial mount so that the default is always light mode.

Preferably this would be added to config for Histoire.

Suggested solution

Add dark mode settings in config.theme and use these in the dark util.

Alternative

No response

Additional context

No response

Validations

@mikael-j-rich mikael-j-rich added the enhancement: to triage New feature of request pending review by team member label Dec 5, 2022
@danielduckworth
Copy link

I'm interested in this also. I'm using Vuetify components which has its own way of handling theme switching. It would be useful if the state could be shared with component framework vendors.

@Akryum Akryum added enhancement New feature or request and removed enhancement: to triage New feature of request pending review by team member labels Dec 19, 2022
Akryum added a commit that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants