-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte plugin: incompatibility with svelte-kit starting from 1.0.0-next.574 #392
Closed
6 tasks done
Labels
to triage
This issue needs to be triaged
Comments
Start a new pull request in StackBlitz Codeflow. |
vnphanquang
added a commit
to vnphanquang/histoire
that referenced
this issue
Dec 9, 2022
10 tasks
vnphanquang
added a commit
to vnphanquang/histoire
that referenced
this issue
Dec 12, 2022
Can confirm, in my case I left Vite at v3, but updating to |
have you seen these fixes @bivainis ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Context
There have been 2 recent releases of svelte-kit that causes
histoire
to fail:1.0.0-next.574, in which the internal
vite-plugin-svelte-kit
was split intovite-plugin-sveltekit-build
andvite-plugin-sveltekit-middleware
in PR #7990.1.0.0-next.576, in which the
sveltekit
vite plugin becameasync
(PR #7994).Resolution
For (1), please see this open PR that updates
viteIgnorePlugins
.For (2), I'm not sure there is a way to get around automatically from
@histoire/plugin-svelte
side; I'm happy to help out further if someone can give me some direction. For now, here is a working workaround for me:Maybe if nothing can be done, then this should be added to the documentation somewhere?
Reproduction
Please run
npm run story:dev
from this StackBlitz. Notice:svelte-kit
app instead ofhistore
,svelte-kit
is reverted to1.0.0-next.573
, everything works as expected.System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: