Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add events (fix #32) #72

Merged
merged 5 commits into from
May 1, 2022
Merged

feat: Add events (fix #32) #72

merged 5 commits into from
May 1, 2022

Conversation

hugoattal
Copy link
Collaborator

fix #32

Description

So I added event handling with a few features:

  • When not in the events tab, you get a small indicator of how much new events have been fired
  • When an event is fired, it's logged in the console for easy inspection
  • On the events panel, you can click on an event to log it to the console (because displaying a deep clone of the event data can be too much...)

Additional context

image

image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal self-assigned this May 1, 2022
@netlify
Copy link

netlify bot commented May 1, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit a4cc183
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/626f1b4307ef450009b5d5b6
😎 Deploy Preview https://deploy-preview-72--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 1, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit a4cc183
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/626f1b43c2943a0008a72797
😎 Deploy Preview https://deploy-preview-72--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 1, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit a4cc183
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/626f1b43759c0a000945e503
😎 Deploy Preview https://deploy-preview-72--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal hugoattal added the enhancement New feature or request label May 1, 2022
@hugoattal
Copy link
Collaborator Author

I suggest disabling the func-call-spacing eslint rule as it seems to have some problem with typescript typing... Wdyt?

@hugoattal hugoattal added the draft label May 1, 2022
@Akryum
Copy link
Member

Akryum commented May 1, 2022

You can rebase :D
101fe08

@hugoattal hugoattal removed the draft label May 1, 2022
@hugoattal hugoattal requested a review from Akryum May 1, 2022 14:15
@hugoattal
Copy link
Collaborator Author

hugoattal commented May 1, 2022

Btw, I don't have any problem running the stories-list.js cypress test on local 😕 ... (and I didn't touch anything related)

That might be a CI bug more than a PR bug 😅

Welp, my bad 😐

@Akryum
Copy link
Member

Akryum commented May 1, 2022

If you add a story you need to increase the story count in the test too :D

@hugoattal
Copy link
Collaborator Author

hugoattal commented May 1, 2022

Weirdly enough, the cypress test actually passed with the 20 length, then I updated to 21, and it still passed. And when I reverted to 20 it didn't pass anymore 😂! In any case, I just fixed it, sorry for this 😅

@Akryum Akryum merged commit 60bd8ae into main May 1, 2022
@Akryum Akryum deleted the feat-events branch May 1, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events
2 participants