Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger setupVue3 in worker (fix #76) #77

Merged
merged 5 commits into from
May 2, 2022
Merged

Conversation

hugoattal
Copy link
Collaborator

Fix #76

Description

Seems like the story sometimes can't compile without the setup being triggered.
I added the setup to be triggered in the worker.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the draft label May 2, 2022
@hugoattal hugoattal self-assigned this May 2, 2022
@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit a8d6b97
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/62700d5c3239b20008d28969
😎 Deploy Preview https://deploy-preview-77--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit a8d6b97
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/62700d5cf029bb000920072e
😎 Deploy Preview https://deploy-preview-77--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit a8d6b97
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/62700d5c7b0af10007d009c7
😎 Deploy Preview https://deploy-preview-77--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal hugoattal changed the title Trigger setup in worker fix: Trigger setupVue3 in worker (fix #76) May 2, 2022
@hugoattal hugoattal requested a review from Akryum May 2, 2022 16:11
@hugoattal hugoattal added bug Something isn't working and removed draft labels May 2, 2022
Copy link
Member

@Akryum Akryum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Switching to importing from '$histoire-setup' would be ideal.

@Akryum Akryum merged commit 323e535 into main May 2, 2022
@Akryum Akryum deleted the fix-worker-setup branch May 2, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use pinia with defineSetupVue3
2 participants