Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add booleanish checkbox #506

Merged
merged 2 commits into from
Apr 11, 2023
Merged

feat: Add booleanish checkbox #506

merged 2 commits into from
Apr 11, 2023

Conversation

hugoattal
Copy link
Collaborator

Fix #502

Description

I added the string value "true" and "false" to possible value of HstCheckbox.
I think it's a good idea to add this feature since having a toggle between "true" and "false" is a valid concern.

If you think it's useless, feel free to close the PR.

Additional context

  • Is the value is a string, it will be updated to a string
  • By default, any string value which is not "false" is considered "true" (but expected input types are "true" or "false" anyway)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@codesandbox
Copy link

codesandbox bot commented Mar 30, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@stackblitz
Copy link

stackblitz bot commented Mar 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hugoattal hugoattal requested a review from Akryum March 30, 2023 17:26
@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit d3121e6
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6425c65c5f9dcb0008600bf2
😎 Deploy Preview https://deploy-preview-506--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit d3121e6
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6425c65c488cc20008608a3c
😎 Deploy Preview https://deploy-preview-506--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit d3121e6
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6425c65c2a9a530008b6ac4b
😎 Deploy Preview https://deploy-preview-506--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit d3121e6
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6425c65c42ebb00008461b69
😎 Deploy Preview https://deploy-preview-506--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Akryum Akryum merged commit b10e3a1 into main Apr 11, 2023
@Akryum Akryum deleted the add-booleanish-checkbox branch April 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use HstCheckbox for toggling Booleanish properties
2 participants