Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pnpm version inconsistency #550

Merged

Conversation

sapphi-red
Copy link
Contributor

Description

6c4e4c7 updated pnpm to 8.6.2 but didn't update the packageManager field.
I guess this broke the vite-ecosystem-ci.
https:/vitejs/vite-ecosystem-ci/actions/runs/5330308448/jobs/9656862024#step:8:302

I also removed the version field from the workflows files as the latest pnpm setup action read the packageManager field.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Jun 21, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit ab435a7
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6492b6fff6b38f0008340197
😎 Deploy Preview https://deploy-preview-550--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit ab435a7
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6492b6ff0a21c4000848ffbf
😎 Deploy Preview https://deploy-preview-550--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit ab435a7
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6492b6ff76fcb7000830b0db
😎 Deploy Preview https://deploy-preview-550--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit ab435a7
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6492b700b5245a000862de4a
😎 Deploy Preview https://deploy-preview-550--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@noel-schenk
Copy link
Contributor

@Akryum can we merge those 2 PRs?

@Akryum Akryum merged commit eeaed3d into histoire-dev:main Jul 6, 2023
@sapphi-red sapphi-red deleted the chore/fix-pnpm-version-inconsistency branch July 6, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants