fix: force display none for HstRadio (fix #537) #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
50rayn
force-pushed
the
fix/hst-radio-hidden
branch
from
6b6d3b1
to
05bcd28
Compare
|
Sorry for these manipulations with force-push. I just wanted to have only one commit and a clean work-tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the issue #537, was installed
@tailwindcss/formswhich adds globally styles for[type="checkbox"], [type="radio"], where isdisplay: inline-block. Even if in HstRadion was addedhtw-hidden, it didn't have enough specificity to overwrite. So, I added "!" to make it important.Fixes #537
Additional context
I would say, my fix is not the perfect one but it at least fixes temporarily the issue. I understand that TailwindCSS speed up development, but it brings problems for users who already use Tailwind and the applied class can be easily overwritten by a stronger specificity selector. I think it should be reviewed the styles appliance and isolation (e.g. scoped style)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).