Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix sandbox URL in getSandboxUrl function #652

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

peterbud
Copy link
Contributor

Fixes #635

Description

Vite's base attribute was not properly considered when generating URLs for stories in single / iframe layout.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Dec 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Dec 22, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit ad493c5
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/65855b4fe71b8d0008b5d61a
😎 Deploy Preview https://deploy-preview-652--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit ad493c5
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/65855b4fb9dda7000818c227
😎 Deploy Preview https://deploy-preview-652--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit ad493c5
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/65855b4fb3bf3600089e101a
😎 Deploy Preview https://deploy-preview-652--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit ad493c5
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/65855b4f9d68740008b760aa
😎 Deploy Preview https://deploy-preview-652--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akryum Akryum changed the title fix(app): Fix sandbox URL in getSandboxUrl function fix: Fix sandbox URL in getSandboxUrl function Jan 15, 2024
@Akryum Akryum merged commit 44adb5c into histoire-dev:main Jan 15, 2024
13 checks passed
Akryum added a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite's base option breaks asset paths
2 participants