-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timezone on clock module #223
Comments
Also, the possibility of adding multiple clocks in different timezones would be a plus! |
I misunderstood this one as being about displaying the current timezone in the clock widget, which can already be done with At the moment, waybar does not detect system timezone changes, but this should be fixed soon (see #479). By default, the clock should reflect the system's timezone. So this feature chiefly adds
|
I'd be happy to work on this (specifically, being able to specify the TZ for a particular clock module), and I think the easiest way to make this happen would be to bring in Howard Hinnant's |
Adding multiple clocks with different time zones is the most important functionality I'm missing when changing from py3status. Is there something I can do to help get this done? |
@mjec @ZeiP Since Alexays seems okay with adding a dependency on tz.h, there remains to make the actual pull request.
Most of this should be straightforward, given that clock.cpp is 31 lines :-). A potential unknown pain point will be the formatting, but I guess there are ways to convert a tz.h time to a more standard value for formatting with fmt. |
PR #560 created which adds timzeone support -- feedback extremely welcome, as I don't normally write C++. |
Add timezone support to clock module (closes #223)
Hi,
Nice project thanks ! It would be nice to be able to set the timezone on the config file so we don't have to bother to set the
TZ
env var and reload the session, wdyt ?Cheers
The text was updated successfully, but these errors were encountered: