Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature startscript #33

Merged
merged 51 commits into from
Mar 29, 2020
Merged

Feature startscript #33

merged 51 commits into from
Mar 29, 2020

Conversation

mmuller88
Copy link
Contributor

@mmuller88 mmuller88 commented Mar 17, 2020

That PR implements a wrapper start script with lots of nice features like

The use is easy and can be seen with ./start -h

Copy link
Contributor

@aborroy aborroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only feature I see is waiting for Alfresco to start. Not sure that this is enough to be added to the project.

generators/app/templates/scripts/start.sh Show resolved Hide resolved
generators/app/index.js Outdated Show resolved Hide resolved
generators/app/index.js Outdated Show resolved Hide resolved
@mmuller88 mmuller88 requested a review from aborroy March 28, 2020 07:42
Copy link
Contributor

@aborroy aborroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aborroy aborroy merged commit 73b6fc7 into Alfresco:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants