Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model node transformations and other improvements #102

Merged
merged 14 commits into from
Dec 3, 2015

Conversation

shunter
Copy link
Member

@shunter shunter commented Dec 3, 2015

This supersedes #101 including all of Greg's changes, and additionally starts working towards wrangling this mess of a project into shape.

CZML now supports the general concept of key-value data, for example:

{
  "model":{
    "nodeTransformations":{
      "node1":{
        "scale":{
          // ...
        }
      }
    }
  }
}

This is generated by specifying "additionalProperties" in the jsonschema, which essentially associates structure with any property, rather than naming specific CZML properties. jsonschema allows for constraining the name of additional properties, but for this use case this is unnecessary.

Along the way I significantly refactored the GenerateFromSchema code. I also took a pass through the existing schema and fixed and improved documentation in a number of places. The concept of nextTime/previousTime has never been supported, and has been removed. Interpolation/extrapolation-related properties were not documented and have been added. The "axes" property on orientation has never been supported, and has been removed. Boolean properties were not allowed to be references, which was an oversight, and has been corrected.

For completeness, additional CZML changes from Greg's PR include a Boolean property runAnimations to control whether animations run on load.

shunter added a commit that referenced this pull request Dec 3, 2015
…ransform

Model node transformations and other improvements
@shunter shunter merged commit 89a3992 into master Dec 3, 2015
@shunter shunter deleted the gbeatty-modelNodeTransform branch December 3, 2015 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants