Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve report messages. #2

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Improve report messages. #2

merged 1 commit into from
Aug 3, 2021

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 3, 2021

the sentinel error EndOfFileError should be of the form ErrXxx -> The variable name EndOfFileError should conform to the ErrXxx format
the error type someTypeWithoutPtr should be of the form xxxError -> The type name someTypeWithoutPtr should conform to the xxxError format

@ldez ldez mentioned this pull request Aug 3, 2021
Merged
@Antonboom Antonboom merged commit 159ef39 into Antonboom:master Aug 3, 2021
@ldez ldez deleted the fix/report-message branch August 3, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonboom Antonboom Antonboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @Antonboom