Re-enable failing tests #2255
Merged
Re-enable failing tests #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable TFM parallelism for dotnet test on the Polly.Core project to see if it is the cause of the two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dotnet-vnext #2255 +/- ##
=============================================
Coverage 85.29% 85.29%
=============================================
Files 312 312
Lines 7426 7426
Branches 1118 1118
=============================================
Hits 6334 6334
Misses 746 746
Partials 346 346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Try only disabling parallelism on Windows where there is the additional `net481` TFM.
|
Looks like the new parallel behaviour in .NET 9 SDK plus the additional 3rd TFM on Windows was what was causing the failures. |
martincostello
merged commit f567882
into
App-vNext:dotnet-vnext
17 of 18 checks passed
martincostello
added a commit
that referenced
this pull request
Aug 17, 2024
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
martincostello
added a commit
that referenced
this pull request
Sep 25, 2024
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
martincostello
added a commit
that referenced
this pull request
Oct 8, 2024
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
martincostello
added a commit
that referenced
this pull request
Oct 11, 2024
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
martincostello
added a commit
that referenced
this pull request
Oct 16, 2024
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests. See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable TFM parallelism for
dotnet testin the Polly.Core project to see if it is the cause of the two failing tests.See What's new in the SDK for .NET 9 - Run tests in parallel.