Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOMs not showing ECG and error in DrawECGCanvas #8

Closed
carlos-actualmed opened this issue Jun 20, 2023 · 1 comment
Closed

DICOMs not showing ECG and error in DrawECGCanvas #8

carlos-actualmed opened this issue Jun 20, 2023 · 1 comment

Comments

@carlos-actualmed
Copy link

Describe the bug
The attached DICOMs do not display anything. Their SOPUIDs are in the 'Currently it works' list.

To Reproduce

  1. Open attached DICOM file using v2.0.5

Expected behavior
The ECG should be displayed

Screenshots
e1:
e1
e2:
e2
e3:
e3
e4:
e4

Desktop (please complete the following information):

  • OS: windows 11
  • Browser: Chrome
  • Version 114.0.5735.134

Additional context
I found a problem in DrawECGCanvas.ts:314. The 'code' is not correctly sanitized, and the 'name' does not correspond to it. This solves the problem:
return obj.name.toUpperCase() === code.trim().replace(/\0/g, "").toUpperCase();
solution

However, this only solves the problem in files e1 and e4.
https://we.tl/t-6pMiYS1e7T

@ArturRod
Copy link
Owner

Hi @carlos-actualmed
The problem is caused by reading data, it appears as Lead I (space) Lead II u\0000, Lead v5\x00... (e1, e2)
image
The second problem is given since the data reading is for 16 bits and these 2 ecgs come from 13 bits.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants