fix(documentarray): set correct document array path if making map of …

…document arrays

Fix #12997

lib/schema/documentarray.js

@@ -416,30 +416,32 @@ DocumentArrayPath.prototype.cast = function(value, doc, init, prev, options) {
 
  options = options || {};
 
+ const path = options.path || this.path;
+
  if (!Array.isArray(value)) {
  if (!init && !DocumentArrayPath.options.castNonArrays) {
  throw new CastError('DocumentArray', value, this.path, null, this);
  }
  // gh-2442 mark whole array as modified if we're initializing a doc from
  // the db and the path isn't an array in the document
  if (!!doc && init) {
- doc.markModified(this.path);
+ doc.markModified(path);
  }
  return this.cast([value], doc, init, prev, options);
  }
 
  // We need to create a new array, otherwise change tracking will
  // update the old doc (gh-4449)
  if (!options.skipDocumentArrayCast || utils.isMongooseDocumentArray(value)) {
- value = new MongooseDocumentArray(value, this.path, doc);
+ value = new MongooseDocumentArray(value, path, doc);
  }
 
  if (prev != null) {
  value[arrayAtomicsSymbol] = prev[arrayAtomicsSymbol] || {};
  }
 
  if (options.arrayPathIndex != null) {
- value[arrayPathSymbol] = this.path + '.' + options.arrayPathIndex;
+ value[arrayPathSymbol] = path + '.' + options.arrayPathIndex;
  }
 
  const rawArray = utils.isMongooseDocumentArray(value) ? value.__array : value;

test/types.documentarray.test.js

@@ -762,4 +762,22 @@ describe('types.documentarray', function() {
 
  assert.ok(doc.subDocArray[0]._id instanceof mongoose.Types.ObjectId);
  });
+
+ it('gets correct path when underneath map (gh-12997)', function() {
+ const mapArraySchema = Schema({
+ myMap: {
+ type: Map,
+ of: [Schema({ name: String })]
+ }
+ });
+
+ const Model = db.model('Test', mapArraySchema);
+ const doc = new Model({
+ myMap: {
+ foo: [{ name: 'bar' }]
+ }
+ });
+
+ assert.equal(doc.myMap.get('foo').$path(), 'myMap.foo');
+ });
 });