Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Up Next Shuffle - Update Up Next Clear #3068

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Oct 21, 2024

Description

  • This PR moves the Clear Queue button to toolbar
  • Display Up Next clear confirmation dialog regardless of the number of episodes in Up Next 5d9cf76
  • I also fixed the font size for the remaining up next time to match with figma bbb19fc
  • See this post for context: pdeCcb-7bN-p2
  • See design: KjyDLK1DPPg3snPBMVGWHw-fi-0_1492

Fixes #3059

Testing Instructions

  1. Have an empty Up Next
  2. Play an episode
  3. Open Up next
  4. ✅ Ensure you don't see the trash can icon since the Up Next is empty
  5. Add one episode to Up Next
  6. ✅ Ensure you see the trash can icon in Up Next
  7. Tap on the trash can icon
  8. ✅ Ensure the up next clear confirmation dialog opens

Screenshots or Screencast

Screen_recording_20241021_114434.webm
Before Small devices Regular Devices
before small device regular device

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added this to the 7.76 milestone Oct 21, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner October 21, 2024 16:03
@mebarbosa mebarbosa requested review from MiSikora and removed request for a team October 21, 2024 16:03
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 21, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitcca8f48
Direct Downloadpocketcasts-app-prototype-build-pr3068-cca8f48.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitcca8f48
Direct Downloadpocketcasts-automotive-prototype-build-pr3068-cca8f48.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitcca8f48
Direct Downloadpocketcasts-wear-prototype-build-pr3068-cca8f48.apk

@CookieyedCodes
Copy link

Make sure the clear que button still pushes up a are you sure prompt, also personally I think the upnext icon with the x is a better icon for clear que instead of a trash icon in my opinion 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Up Next Shuffle - Update confirmation modal for clear action
3 participants