Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-year support for End of Year/Playback #2306

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 18, 2024

📘 Part of: #2250

Part of #2305

This refactors EndOfYear to include support for multiple years.

The intent is that this PR changes nothing with regards to the previous end of year projects. 2024 support will be in a separate PR due to line count.

To test

Note

You will need to have sufficient listening history. Ping me if you want a database to import to speed that up.

  • Enable endOfYear feature flag
  • Tap the Reset modal/profile badge option in Developer menu
  • Restart the app
  • Navigate to Profile and ensure "Your Year in Podcasts" 2023 banner is showing
  • Tap the banner and ensure Stories load and you can tap through them

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Oct 18, 2024
@bjtitus bjtitus requested a review from a team as a code owner October 18, 2024 19:17
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team October 18, 2024 19:17
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 18, 2024

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@bjtitus bjtitus added this to the 7.76 milestone Oct 18, 2024
@bjtitus
Copy link
Contributor Author

bjtitus commented Oct 18, 2024

Sorry for the large line count on this. There was a lot of code moved to different files for better organization and lots of boilerplate I wanted to parameterize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants