Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking of the notifications global state #695

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

xristos3490
Copy link
Member

@xristos3490 xristos3490 commented Oct 2, 2024

Description

This PR adds tracking of the global notification reminders state of a store within the WC_Tracker snapshot.

How to test this PR

  1. Install a snippet to run the data fetching function on init. Like the following:
add_action( 'init', function() {
    error_log( 
        print_r(
            WC_Subscriptions_Tracker::add_subscriptions_tracking_data( array( 'extensions' => array( 'wc_subscriptions' => array() ),
            true,
        )
    );
}
  1. Monitor server logs.
  2. Ensure that the newly added setting is working as expected while you change the global setting.

Product impact

  • Added changelog entry (or does not apply)
  • Will this PR affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
  • Will this PR affect WooCommerce Payments? yes/no/tbc, add issue ref
  • Added deprecated functions, hooks or classes to the spreadsheet

@xristos3490 xristos3490 changed the base branch from trunk to try/subs-notifications-pf October 2, 2024 12:22
@xristos3490 xristos3490 marked this pull request as ready for review October 2, 2024 12:26
@xristos3490 xristos3490 self-assigned this Oct 2, 2024
Copy link

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info gets included and reflects the setting correctly ✅ . Thanks!

@peterfabian peterfabian merged commit 70f90b7 into try/subs-notifications-pf Oct 18, 2024
9 checks passed
@peterfabian peterfabian deleted the add/tracking-notifications branch October 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants