Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 Support #213

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Swift 5 Support #213

wants to merge 8 commits into from

Conversation

jguffey
Copy link

@jguffey jguffey commented Sep 15, 2019

  • Changes iOS build target to 10
  • Compiles for Swift 5

Working and compiling using Swift 5. If you are interested in merging this to master, I can fix the conflicts. Thanks,

@PoeticPete
Copy link

@Awalz any plans on supporting Swift 5? Would love to see this merged

NotificationCenter.default.removeObserver(self)
sessionRunning = false
// If session is running, stop the session
// if self.isSessionRunning == true {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want the session to stop running when the vc disappears

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes you're right. This edit may have been too coupled to my use case.

@jguffey
Copy link
Author

jguffey commented Apr 30, 2021

It's been a couple years since I last worked on anything iOS. I probably won't have time to clean up this PR's conflicts nor respond to feedback, but hopefully this PR helps someone else bring SwitftyCam up to Swift5 support.

@Jaspur
Copy link

Jaspur commented Mar 31, 2022

@Awalz can you merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants