Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AB#40568] channel id changed in catalog service to match other entities #104

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

AxTrusov
Copy link
Member

@AxTrusov AxTrusov commented Jul 10, 2023

Pull Request

Prerequisites

  • My code follows the coding conventions
  • All tests pass

Description

To match other entities, channel ID is now explicitly adjusted in catalog service, adding a channel- prefix to the original UUID value. Corresponding changes are made in the entitlement service to support this. And explicit database migration is added to update possible existing channel entries in the channel service database.

Testing Notes

Publish a channel, make sure that catalog API would return a valid id value (e.g. channel-92b27f89-ac27-4e50-8fe7-e4cd75a5855e) when querying channels and channel images. IF VOD-to-live service is configured to enable DRM protection - make sure that passing the updated channel id to the entitlement endpoint would return the entitlement token.

@AxTrusov AxTrusov requested a review from Zehelein July 10, 2023 07:20
@AxTrusov AxTrusov changed the base branch from main to dev July 10, 2023 07:20
@AxTrusov AxTrusov merged commit a180c49 into dev Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants