Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from admission/v1beta1 to admission/v1 #1

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

Sonlis
Copy link
Contributor

@Sonlis Sonlis commented Feb 3, 2021

As admissionregistration.k8s.io/v1beta1 is deprecated in kubernetes 1.16, removed in 1.22, some changes need to be done.

Changes:

  • The AdmissionResponse needs more field to be set. Kind, apiVersion and response.uid are now forced to be filled, otherwise the AdmissionResponse is dismissed, which wasn't the case in admission/v1beta1. Ref: Promote admissionreview to v1 kubernetes/kubernetes#80231
  • In the webhook deployment, 2 fields are added to match v1 rules.
  • Import modules from GitHub instead of ambidexter repos.
  • Use go.mod and go.sum, which is a newer way to manage dependencies in Go.

@AymenSegni
Copy link
Owner

As admissionregistration.k8s.io/v1beta1 is deprecated in kubernetes 1.16, removed in 1.22, some changes need to be done.

Changes:

  • The AdmissionResponse needs more field to be set. Kind, apiVersion and response.uid are now forced to be filled, otherwise the AdmissionResponse is dismissed, which wasn't the case in admission/v1beta1. Ref: kubernetes/kubernetes#80231
  • In the webhook deployment, 2 fields are added to match v1 rules.
  • Import modules from GitHub instead of ambidexter repos.
  • Use go.mod and go.sum, which is a newer way to manage dependencies in Go.

Good Job @Sonlis 👏
Thanks!

@AymenSegni AymenSegni merged commit 246c908 into AymenSegni:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants