Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2: ASIM Parsers, connector optimizations/enhancements #10994

Merged
merged 62 commits into from
Oct 17, 2024

Conversation

ashwinvenkatesha
Copy link
Contributor

Required items, please complete

Change(s):

  • Added ASIM parser for audit and network session schema
  • Made connector optimizations and added an option to ingest traffic data based on policy decision

Reason for Change(s):

  • Adding new functionality
  • Improving scope of solution

Version Updated:

  • Required only for Detections/Analytic Rule templates

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

@v-prasadboke v-prasadboke self-assigned this Aug 22, 2024
@v-atulyadav v-atulyadav added Connector Connector specialty review needed Solution Solution specialty review needed labels Aug 26, 2024
@ashwinvenkatesha ashwinvenkatesha marked this pull request as ready for review September 19, 2024 10:48
@vakohl
Copy link
Contributor

vakohl commented Oct 10, 2024

hi @v-atulyadav @v-prasadboke ,
I've reviewed the ASim parser changes. All changes except one csv related comment is left, once that is resolved, parser changes are approved from my side. Can you please help reviewing the solution specific files in this PR?
@ashwinvenkatesha FYI

@v-prasadboke
Copy link
Contributor

As discussed in the call
Ashwin can you please move this PR to draft state

@ashwinvenkatesha
Copy link
Contributor Author

As discussed in the call Ashwin can you please move this PR to draft state

I have made my changes and its ready to be merged.
Please proceed with updating the azuredeploy with master branch link once merged.

@v-sudkharat v-sudkharat linked an issue Oct 17, 2024 that may be closed by this pull request
@v-atulyadav v-atulyadav merged commit 3bca631 into Azure:master Oct 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASIM Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error reporting in azure devops for sentinel builds
5 participants