Reclaim reserved buffer for unused ports #831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
201911 PRs
Master PRs (currently draft)
202106 PRs
202012 PRs
Reclaim reserved buffer for unused ports.
Originally, the reserved buffer is reclaimed by removing buffer objects of the unused ports. However, this introduces inconsistency. Consider the following scenarios:
Now we have two scenarios with the same SONiC buffer configuration, resulting in different buffer configurations in ASIC.
To resolve this issue:
zero buffer profiles
are introduced to indicate 0 reserved size of a buffer object.The solution:
The zero profiles and pools will be handled in different ways between the dynamic and traditional buffer models.