Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CosmosClientBuilder.WithConnectionModeGateway documentation #3641

Closed
arthuraugsten opened this issue Jan 10, 2023 · 1 comment · Fixed by #3643
Closed

Fix CosmosClientBuilder.WithConnectionModeGateway documentation #3641

arthuraugsten opened this issue Jan 10, 2023 · 1 comment · Fixed by #3643
Labels
documentation

Comments

@arthuraugsten
Copy link
Contributor

Hey,

The documentation for CosmosClientBuilder.WithConnectionModeGateway is a bit confuse. This one is saying that the parameter maxConnectionLimit is the time that the client will wait, however, in the end, it is saying about number of connections, and the value is not the current default value! I've analyzed and this value is used on HttpMessageHandler.MaxConnectionsPerServer.

Follow a suggestion for the documentation.
The number specifies the number of connections which may be executed simultaneously. Default is 50 connections.

I was not able to create a branch and a PR with this suggestion.
@ealsur
Copy link
Member

ealsur commented Jan 10, 2023

@arthuraugsten Thanks for your feedback, can you fork the repository, create a branch and send a PR from your fork?

@arthuraugsten arthuraugsten mentioned this issue Jan 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
2 participants
@ealsur @arthuraugsten