Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

low allocs (draft) #249

Merged
merged 47 commits into from
Aug 25, 2024
Merged

low allocs (draft) #249

merged 47 commits into from
Aug 25, 2024

Conversation

AsafMah
Copy link
Contributor

@AsafMah AsafMah commented Jun 9, 2024 •
edited
Loading

Changed

  • IterativeTable.Skip() was renamed to IterativeTable.IsSkipped() to avoid confusion.
  • V2FrameCapacity was renamed to V2IoCapacity to better reflect its purpose.
  • V2FragmentCapacity was renamed to V2TableCapacity to better reflect its purpose.
  • Better defaults for buffer sizes.

Fixed

  • Fixed plenty of sync issues.
  • Reduced allocations.

@AsafMah AsafMah marked this pull request as draft June 9, 2024 09:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 883ea2e. ± Comparison against base commit 61e608f.

♻️ This comment has been updated with latest results.

yogilad
yogilad approved these changes Aug 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
azkustodata/query/v2/fast_json.go Outdated Show resolved Hide resolved
@AsafMah
Merge branch 'master' into low-allocations
4fd1049 
# Conflicts:
#	azkustoingest/test/etoe/etoe_test.go
@AsafMah AsafMah merged commit 425230d into master Aug 25, 2024
6 checks passed
@AsafMah AsafMah deleted the low-allocations branch August 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogilad yogilad yogilad approved these changes

@ohadbitt ohadbitt Awaiting requested review from ohadbitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsafMah @yogilad