feat(kcsb): support use of managed identity resource id

[sgoings]

feat(kcsb): support use of managed identity resource id

deprecate WithUserManagedIdentity, with more specific replacements:

• WithUserAssignedIdentityClientId - Receives the MSI client id
• WithUserAssignedIdentityResourceId - Receives the MSI resource id

[AsafMah]

Making it a heuristic is not great, it's probably better to have it as an explicit different parameter.

[sgoings]

Making it a heuristic is not great, it's probably better to have it as an explicit different parameter.

The way I'd see this working best is if WithUserAssignedIdentity(...) takes a struct ManagedIdentityOpts with fields AppID or ResourceID and then storing that struct as ManagedServiceIdentity in ConnectionStringBuilder. Another option is to have 2 string fields in the function signature of WithUserAssignedIdentity(...) but... not sure how willing you are to break API compat here.

Another way to handle it could be to have another function (such as WithUserAssignedIdentityV2(opts ManagedIdentityOpts)) and not change behavior of the existing WithUserAssignedIdentity function.

What direction would you prefer me take this?

[AsafMah]

I think we should deprecate the old method, add two new methods - WithUserAssignedIdentityClientId and WithUserAssignedIdentityResourceId, and have old one redirect to the client id method.

[sgoings]

@AsafMah ptal

[AsafMah]

Looks great - thanks