Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters #15

Merged
merged 17 commits into from Dec 3, 2014
Merged

Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters #15

merged 17 commits into from Dec 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Nov 26, 2014

No description provided.

@azurecla
Copy link

Hi @daschult, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (daschult). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@@ -82,11 +82,11 @@
</Reference>
<Reference Include="Microsoft.WindowsAzure.Common, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.0\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.1\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating only one project out of the solution to a newer NuGet package may cause run-time issues. Please update all projects in the AzurePowerShell.sln solution with the latest package.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stankovski
Copy link
Member

Please add mock scenario tests

@stankovski
Copy link
Member

Please update documentation xml file

@markcowl
Copy link
Member

markcowl commented Dec 2, 2014

Build is failing, Loks like a removed reference to common?

@ghost
Copy link
Author

ghost commented Dec 2, 2014

retest this please

@@ -0,0 +1,93 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a new psd1 file is added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it didn't exist previously. I don't know why I didn't have it, but I do now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this makes it easier to edit our powershell help file. I'd like to keep it around.

ogail added a commit that referenced this pull request Dec 3, 2014
Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters
@ogail ogail merged commit 18dd916 into Azure:dev Dec 3, 2014
ogail pushed a commit that referenced this pull request Feb 25, 2015
Bug fixes and Associate protection profile skeleton
huangpf referenced this pull request in huangpf/azure-powershell Mar 5, 2015
removing commented code and credentials
ogail pushed a commit that referenced this pull request Mar 18, 2015
pull from dev branch of azure/azure-powershell
akromm-zz pushed a commit to akromm-zz/azure-powershell that referenced this pull request Apr 18, 2015
stankovski pushed a commit that referenced this pull request May 19, 2015
huangpf added a commit that referenced this pull request Jun 8, 2015
ogail pushed a commit that referenced this pull request Jul 7, 2015
Fixing the Error Messages shown when decrytion fails with the given regi...
stankovski pushed a commit that referenced this pull request Jul 10, 2015
changes few function names
hovsepm pushed a commit that referenced this pull request Jan 28, 2016
Added DSC delete cmdlets
viananth pushed a commit to viananth/azure-powershell that referenced this pull request Mar 29, 2018
Fixing examples for Commerce, Compute, Fabric, Gallery and Bridge
cormacpayne pushed a commit that referenced this pull request Apr 16, 2019
romahamu pushed a commit to romahamu/azure-powershell that referenced this pull request May 4, 2020
Remove-AzHpcCacheStorageTarget and Upgrade-AzHpcCache cmdlets
isra-fel pushed a commit that referenced this pull request Apr 25, 2022
dantecit0 added a commit to dantecit0/azure-powershell that referenced this pull request Jul 3, 2023
Added exmple Azure#15 which shows how to properly add or remove Availability zones to an Azure Firewall.
Nickcandy pushed a commit that referenced this pull request Jul 4, 2023
Added exmple #15 which shows how to properly add or remove Availability zones to an Azure Firewall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants