[Az.RecoveryServices.Backup] Fixed bugs, added documentation and examples #22159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| 3 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupItem -VaultId $suspendVault.ID is a null-valued parameter value. | -VaultId | Assign value for $suspendVault.ID. | ||
| 3 | 2 | Unassigned_Variable | Disable-AzRecoveryServicesBackupProtection -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. | ||
| 3 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupItem -VaultId $suspendVault.ID is a null-valued parameter value. | -VaultId | Assign value for $suspendVault.ID. | ||
| 4 | 12 | Mismatched_Parameter_Value_Type | Set-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $pol.RetentionPolicy is not an expected parameter value type. | -RetentionPolicy | Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RetentionPolicyBase. Now the type is .(Command). | ||
| 4 | 18 | Mismatched_Parameter_Value_Type | Compare-Object -[-ReferenceObject] $rpsBefore is not an expected parameter value type. | $rpsBefore | Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command). | ||
| 4 | 18 | Mismatched_Parameter_Value_Type | Compare-Object -[-DifferenceObject] $rpsAfter is not an expected parameter value type. | $rpsAfter | Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command). | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. | -Item | Assign value for $SQLBkpItem. | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. | $startdate | Assign value for $startdate. | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. | $enddate | Assign value for $enddate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. | -Item | Assign value for $SQLBkpItem. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. | $startdate | Assign value for $startdate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. | $enddate | Assign value for $enddate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetItem $SQLProtItem is a null-valued parameter value. | -TargetItem | Assign value for $SQLProtItem. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetContainer $targetVMContainer is a null-valued parameter value. | -TargetContainer | Assign value for $targetVMContainer. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| 3 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupItem -VaultId $suspendVault.ID is a null-valued parameter value. | -VaultId | Assign value for $suspendVault.ID. | ||
| 3 | 2 | Unassigned_Variable | Disable-AzRecoveryServicesBackupProtection -VaultId $vault.ID is a null-valued parameter value. | -VaultId | Assign value for $vault.ID. | ||
| 3 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupItem -VaultId $suspendVault.ID is a null-valued parameter value. | -VaultId | Assign value for $suspendVault.ID. | ||
| 4 | 12 | Mismatched_Parameter_Value_Type | Set-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $pol.RetentionPolicy is not an expected parameter value type. | -RetentionPolicy | Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RetentionPolicyBase. Now the type is .(Command). | ||
| 4 | 18 | Mismatched_Parameter_Value_Type | Compare-Object -[-ReferenceObject] $rpsBefore is not an expected parameter value type. | $rpsBefore | Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command). | ||
| 4 | 18 | Mismatched_Parameter_Value_Type | Compare-Object -[-DifferenceObject] $rpsAfter is not an expected parameter value type. | $rpsAfter | Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command). | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. | -Item | Assign value for $SQLBkpItem. | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. | $startdate | Assign value for $startdate. | ||
| 1 | 1 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. | $enddate | Assign value for $enddate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. | -Item | Assign value for $SQLBkpItem. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. | $startdate | Assign value for $startdate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. | $enddate | Assign value for $enddate. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetItem $SQLProtItem is a null-valued parameter value. | -TargetItem | Assign value for $SQLProtItem. | ||
| 1 | 2 | Unassigned_Variable | Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetContainer $targetVMContainer is a null-valued parameter value. | -TargetContainer | Assign value for $targetVMContainer. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
vidai-msft
requested changes
Jun 26, 2023
...eryServices.Backup/Cmdlets/Restore/GetAzureRmRecoveryServicesBackupWorkloadRecoveryConfig.cs
Show resolved
Hide resolved
|
@hiaga can you please also add test cases to verify the code change? |
Fixed bug with rp expiry time, making 30 days expiry time for adhoc backup as default from client side. Added example to fetch pruned recovery points after modify policy. Fixed the documentation for suspend backups with immutability. Updated changelog
vidai-msft
reviewed
Jun 26, 2023
...eryServices.Backup/Cmdlets/Restore/GetAzureRmRecoveryServicesBackupWorkloadRecoveryConfig.cs
Show resolved
Hide resolved
vidai-msft
reviewed
Jun 26, 2023
...RecoveryServices/RecoveryServices.Backup/Cmdlets/Jobs/GetAzureRmRecoveryServicesBackupJob.cs
Show resolved
Hide resolved
...yServices/RecoveryServices.Backup/Cmdlets/Jobs/GetAzureRmRecoveryServicesBackupJobDetails.cs
Show resolved
Hide resolved
...Services/RecoveryServices.Backup/Cmdlets/Restore/RestoreAzureRMRecoveryServicesBackupItem.cs
Show resolved
Hide resolved
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vidai-msft
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug with rp expiry time, making 30 days expiry time for adhoc backup as default from client side. Added example to fetch pruned recovery points after modify policy. Fixed the documentation for suspend backups with immutability.
Description
Regenerated CRR SDK. Fixed issues with SQL CRR.
Fixed bug with rp expiry time, making 30 days expiry time for adhoc backup as default from client side.
Added example to fetch pruned recovery points after modify policy.
Fixed the documentation for suspend backups with immutability.
Regenerated CRR SDK. Fixed issues with SQL CRR.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.