Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the way to parse the example #22178

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Fix the way to parse the example #22178

merged 5 commits into from
Jun 27, 2023

Commits on Jun 21, 2023

  1. Use PredictionContext to get the command ast. 

    - The existing way of using Parser.ParseInput doesn't create the CommandAst accurately especially
when the input include `@{}`. So we change to use PredictionContext that is also used by PSReadLine.
    @kceiw
    kceiw committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8e7b572 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add unit test

    @kceiw
    kceiw committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    aac112f View commit details
    Browse the repository at this point in the history

  2. Unify the way to get command name from the example and the user input

    @kceiw
    kceiw committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    229da3b View commit details
    Browse the repository at this point in the history

  3. Remove one test case since that is not what we have in the example

    @kceiw
    kceiw committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    dfbab29 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge remote-tracking branch 'origin/main' into mahuang/FixParsing

    @kceiw
    kceiw committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5a98ab2 View commit details
    Browse the repository at this point in the history