Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed maximum number for IpAddressRange and VirtualNetworkResourceId in *-AzKeyVaultNetworkRuleSet* #22192

Merged
merged 3 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/KeyVault/KeyVault/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Removed maximum number for `IpAddressRange` and `VirtualNetworkResourceId` in `*-AzKeyVaultNetworkRuleSet*` from client side. [#22137]

## Version 4.10.0
* Added breaking change announcement for parameter `SoftDeleteRetentionInDays` in `New-AzKeyVaultManagedHsm`. The parameter `SoftDeleteRetentionInDays` is becoming mandatory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@ public class KeyVaultNetworkRuleSetBase : KeyVaultManagementCmdletBase
/// </summary>
[Parameter(Mandatory = false,
HelpMessage = "Specifies allowed network IP address range of network rule.")]
[ValidateCount(0, 127)]
public string[] IpAddressRange { get; set; }

/// <summary>
/// Virtual network resource IDs for network rule set
/// </summary>
[Parameter(Mandatory = false,
HelpMessage = "Specifies allowed virtual network resource identifier of network rule.")]
[ValidateCount(0, 127)]
public string[] VirtualNetworkResourceId { get; set; }

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,11 @@ public class NewAzureKeyVaultNetworkRuleSetObject : KeyVaultManagementCmdletBase

[Parameter(Mandatory = false,
HelpMessage = "Specifies allowed network IP address range of network rule.")]
[ValidateCount(0, 127)]
[ValidateNotNull]
public string[] IpAddressRange { get; set; }

[Parameter(Mandatory = false,
HelpMessage = "Specifies allowed virtual network resource identifier of network rule.")]
[ValidateCount(0, 127)]
[ValidateNotNull]
public string[] VirtualNetworkResourceId { get; set; }

Expand All @@ -62,4 +60,4 @@ public override void ExecuteCmdlet()
));
}
}
}
}