Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git action to process the event of pr labeled #22285

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

wyunchi-ms
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 10, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add more rules in the future, do we need to repeat line 11 to line 17?

.github/workflows/pr-labeled.yml Outdated Show resolved Hide resolved
@Azure Azure deleted a comment from github-actions bot Jul 10, 2023
@wyunchi-ms wyunchi-ms added AAD Domain Service AAD Graph Deprecating AAD Graph endpoint and removed AAD Domain Service AAD Graph Deprecating AAD Graph endpoint labels Jul 10, 2023
@wyunchi-ms wyunchi-ms force-pushed the wyunchi/breaking-change-actions branch from 8cee2ad to 3095790 Compare July 12, 2023 01:45
@Azure Azure deleted a comment from github-actions bot Jul 12, 2023
@Azure Azure deleted a comment from github-actions bot Jul 12, 2023
@Azure Azure deleted a comment from github-actions bot Jul 12, 2023
@wyunchi-ms wyunchi-ms added AAD Graph Deprecating AAD Graph endpoint and removed Do Not Merge 🚫 AAD Graph Deprecating AAD Graph endpoint labels Jul 12, 2023
@isra-fel isra-fel added the Breaking Change Release This PR contains breaking change label Jul 12, 2023
.github/workflows/pr-labeled.yml Show resolved Hide resolved
.github/workflows/script/PrLabeled.ps1 Show resolved Hide resolved
.github/workflows/script/PrLabeled.ps1 Outdated Show resolved Hide resolved
.github/workflows/script/PrLabeled.ps1 Outdated Show resolved Hide resolved
@wyunchi-ms wyunchi-ms added Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. and removed Breaking Change Release This PR contains breaking change labels Jul 24, 2023
@wyunchi-ms wyunchi-ms added Do Not Merge 🚫 Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. and removed Do Not Merge 🚫 Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. labels Jul 24, 2023
@Azure Azure deleted a comment from github-actions bot Jul 24, 2023
@Azure Azure deleted a comment from github-actions bot Jul 24, 2023
@Azure Azure deleted a comment from github-actions bot Jul 24, 2023
@Nickcandy Nickcandy merged commit 71558d0 into main Jul 24, 2023
14 checks passed
@wyunchi-ms wyunchi-ms deleted the wyunchi/breaking-change-actions branch July 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants