Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suppress for release branch #22420

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

Nickcandy
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Breaking Change Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
Add-AzVMDataDisk The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed. Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'.
Get-AzRestorePoint The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMOSDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'. Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'.
Get-AzRestorePoint The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMDataDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'. Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'.
New-AzVmssIpConfig The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed. Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'.
❌Windows PowerShell - Windows
Type Cmdlet Description Remediation
Add-AzVMDataDisk The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed. Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'.
Get-AzRestorePoint The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMOSDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'. Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'.
Get-AzRestorePoint The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMDataDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'. Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'.
New-AzVmssIpConfig The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed. Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'.
️✔️Az.ContainerRegistry
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy Nickcandy changed the base branch from main to release-2023-08-01 July 25, 2023 15:01
@dolauli dolauli merged commit ef9abdc into release-2023-08-01 Jul 26, 2023
8 of 12 checks passed
@dolauli dolauli deleted the lnx/release-suppress branch July 26, 2023 08:06
NoriZC added a commit that referenced this pull request Aug 2, 2023
* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <[email protected]>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <[email protected]>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: nanxiangLiu <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
wyunchi-ms added a commit that referenced this pull request Aug 4, 2023
* Test removing deps.json

* Test removing deps.json

* Merge main (#22470)

* Added PreTask and PostTask in model to fix breaking changes. (#22421)

* Added PreTask and PostTask in model to fix breaking changes.

* Removed positional mapping and ignored pretask and post task attributes

---------

Co-authored-by: Kalpesh Chavan <[email protected]>

* Add alias for some properties to avoid breaking change for keyvault (#22424)

* Revert "Update DedicatedHostUpdateMethod.cs (#22408)" (#22417)

This reverts commit 7cfc158.

* Revert "[Compute] New cmdlets Get-AzHostSize and Update-AzHost (#22381)"

This reverts commit c8e54e2.

* Revert "update SDK package to use latest REST API version calls  (#22337)"

This reverts commit 7407fb0.

* Migrate StackHCI from generation to release-2023-08-01 (#22427)

* Move StackHCI to release-2023-08-01

* Create BreakingChangeIssues.csv

---------

Co-authored-by: NanxiangLiu <[email protected]>

* Update Az.Batch.psd1 (#22425)

* Update Az.Batch.psd1

* Update ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

* Update src/Batch/Batch/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>

* add suppress for release branch (#22420)

* add suppress for breaking change

* add suppress for breaking change

* Delete SignatureIssues.csv

* Delete BreakingChangeIssues.csv

* release-2023-08-01 (#22434)

* Bumped version to Az 10.2.0

* remove preview json file

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* Add UX metadata for MariaDB and PostgreSql (#22412)

* Update the reference of Azure PowerShell Common to 1.3.82-preview (#22442)

---------

Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: nanxiangLiu <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Yan Xu <[email protected]>

* test removing deps.json2

---------

Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Kalpesh Chavan <[email protected]>
Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: nanxiangLiu <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants