Add PrivateEndpointVNetPolicies parameter #26091

wdehrich · 2024-09-12T18:14:45Z

Description

As part of the new PL64K feature, I am exposing the NRP virtual network property PrivateEndpointVNetPolicies.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-09-12T18:14:48Z

️✔️Az.Accounts

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

⚠️Az.KeyVault

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

⚠️Az.NetAppFiles

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

️✔️Az.Sql

️✔️Az.Storage

️✔️Az.Websites

msJinLei · 2024-09-14T19:05:25Z

@wdehrich Please note the release-network-2024-03-01 is going to removing #26080

msJinLei · 2024-09-18T03:45:11Z

src/Network/Network/VirtualNetwork/NewAzureVirtualNetworkCommand.cs

+ ValueFromPipelineByPropertyName = true,
+ HelpMessage = "The PrivateEndpointVNetPolicies of the virtual network")]
+ public string PrivateEndpointVNetPoliciesValue { get; set; }
+


Please update the help doc for the cmdlet. Refer to https:/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md

github-actions · 2024-09-18T03:45:48Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

msJinLei · 2024-09-21T21:45:19Z

@wdehrich Please fix the failed test case

  [xUnit.net 00:07:34.37]     Commands.Network.Test.ScenarioTests.VirtualNetworkTests.TestVirtualNetworkPrivateEndpointVNetPolicies [FAIL]
    Failed Commands.Network.Test.ScenarioTests.VirtualNetworkTests.TestVirtualNetworkPrivateEndpointVNetPolicies [1 s]
EXEC : error Message:  [D:\a\_work\1\s\build.proj]
     System.Management.Automation.RuntimeException : Assertion failed because the expected object 'Disabled' does not match the actual ''.
  ---- System.Management.Automation.RuntimeException : Assertion failed because the expected object 'Disabled' does not match the actual ''.
    Stack Trace:
       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
     at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
     at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
     at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.Invoke()
     at Microsoft.Azure.Commands.TestFx.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\_work\1\s\tools\TestFx\EnvironmentSetupHelper.cs:line 538
     at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScriptCore(Action setUp, Action`1 contextAction, Action tearDown, String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 255
     at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScript(String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 221
     at Commands.Network.Test.ScenarioTests.VirtualNetworkTests.TestVirtualNetworkPrivateEndpointVNetPolicies() in D:\a\_work\1\s\src\Network\Network.Test\ScenarioTests\VirtualNetworkTests.cs:line 218
  ----- Inner Stack Trace -----

The code completion date is 9.23. If you don't catch the date, you can release the change in the next release or request an OOB

…does not follow the enforced naming convention of using a singular noun for a parameter name.

msJinLei · 2024-10-15T04:18:10Z

/azp run azure-powershell - security-tools

azure-pipelines · 2024-10-15T04:18:19Z

Azure Pipelines successfully started running 1 pipeline(s).

msJinLei · 2024-10-15T04:19:15Z

LGTM

* Add PrivateEndpointVNetPolicies parameter * Update format.ps1xml * Some boilerplate code * Some more boilerplate code * Test * Fix * Parameter PrivateEndpointVNetPolicies of cmdlet New-AzVirtualNetwork does not follow the enforced naming convention of using a singular noun for a parameter name. * Update ChangeLog * Fix parameter name * Fix change log * Able to run test now * Creating a virtual network * Looks like default behavior is working * Fix comments * Setting PrivateEndpointVNetPolicies to Basic works * Enabling for PL64K is working * Disabling for PL64K is working * Testing is working * Update help file New-AzVirtualNetwork.md * Fix NrpTeamAlias --------- Co-authored-by: Will Ehrich <[email protected]>

* Add PrivateEndpointVNetPolicies parameter * Update format.ps1xml * Some boilerplate code * Some more boilerplate code * Test * Fix * Parameter PrivateEndpointVNetPolicies of cmdlet New-AzVirtualNetwork does not follow the enforced naming convention of using a singular noun for a parameter name. * Update ChangeLog * Fix parameter name * Fix change log * Able to run test now * Creating a virtual network * Looks like default behavior is working * Fix comments * Setting PrivateEndpointVNetPolicies to Basic works * Enabling for PL64K is working * Disabling for PL64K is working * Testing is working * Update help file New-AzVirtualNetwork.md * Fix NrpTeamAlias --------- Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]>

msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Sep 14, 2024

msJinLei mentioned this pull request Sep 15, 2024

PowerShell Release Network 2024 03 01 #26080

Merged

6 tasks

msJinLei requested changes Sep 18, 2024

View reviewed changes

msJinLei added needs-revision and removed needs-author-feedback More information is needed from author to address the issue. labels Sep 18, 2024

msJinLei assigned wdehrich Sep 18, 2024

msJinLei mentioned this pull request Sep 19, 2024

Merge release-network-2024-03-01 to main #26136

Merged

6 tasks

msJinLei changed the base branch from release-network-2024-03-01 to main September 20, 2024 04:32

wdehrich force-pushed the wehrich/pl64k branch from 229a152 to 25d5a1b Compare September 20, 2024 04:47

wdehrich force-pushed the wehrich/pl64k branch from 4556b1b to f2feb55 Compare October 8, 2024 14:12

Will Ehrich added 16 commits October 14, 2024 19:21

Add PrivateEndpointVNetPolicies parameter

cfd21b2

Update format.ps1xml

b5575aa

Some boilerplate code

f4ae8d4

Some more boilerplate code

bfe7aff

Test

5157508

Fix

1a4c5e8

Parameter PrivateEndpointVNetPolicies of cmdlet New-AzVirtualNetwork …

7dcf010

…does not follow the enforced naming convention of using a singular noun for a parameter name.

Update ChangeLog

229195c

Fix parameter name

27a7eeb

Fix change log

f289896

Able to run test now

04be561

Creating a virtual network

411d2ee

Looks like default behavior is working

cb5deec

Fix comments

aed7709

Setting PrivateEndpointVNetPolicies to Basic works

c09a59d

Enabling for PL64K is working

f6bb1a2

Will Ehrich added 4 commits October 14, 2024 19:21

Disabling for PL64K is working

e930217

Testing is working

bff4040

Update help file New-AzVirtualNetwork.md

eb77b0b

Fix NrpTeamAlias

1a71b55

wdehrich force-pushed the wehrich/pl64k branch from f349c00 to 1a71b55 Compare October 15, 2024 02:21

msJinLei added Waiting for CI and removed needs-revision labels Oct 15, 2024

msJinLei approved these changes Oct 15, 2024

View reviewed changes

msJinLei merged commit add755e into Azure:main Oct 15, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PrivateEndpointVNetPolicies parameter #26091

Add PrivateEndpointVNetPolicies parameter #26091

wdehrich commented Sep 12, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 12, 2024 •

edited

Loading

msJinLei commented Sep 14, 2024

msJinLei Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

msJinLei commented Sep 21, 2024

msJinLei commented Oct 15, 2024

azure-pipelines bot commented Oct 15, 2024

msJinLei commented Oct 15, 2024

Add PrivateEndpointVNetPolicies parameter #26091

Add PrivateEndpointVNetPolicies parameter #26091

Conversation

wdehrich commented Sep 12, 2024 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Sep 12, 2024 • edited Loading

msJinLei commented Sep 14, 2024

msJinLei Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

msJinLei commented Sep 21, 2024

msJinLei commented Oct 15, 2024

azure-pipelines bot commented Oct 15, 2024

msJinLei commented Oct 15, 2024

wdehrich commented Sep 12, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 12, 2024 •

edited

Loading

msJinLei Sep 18, 2024 •

edited

Loading