Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.Dns] Add NAPTR support and tests #26239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhiteHorseV
Copy link

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 8, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Signature Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
Add-AzDnsRecordConfig Parameter Flags of cmdlet Add-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Add-AzDnsRecordConfig Parameter Services of cmdlet Add-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzDnsRecordConfig Parameter Flags of cmdlet New-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzDnsRecordConfig Parameter Services of cmdlet New-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Remove-AzDnsRecordConfig Parameter Flags of cmdlet Remove-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Remove-AzDnsRecordConfig Parameter Services of cmdlet Remove-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
❌Windows PowerShell - Windows
Type Cmdlet Description Remediation
Add-AzDnsRecordConfig Parameter Flags of cmdlet Add-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Add-AzDnsRecordConfig Parameter Services of cmdlet Add-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzDnsRecordConfig Parameter Flags of cmdlet New-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzDnsRecordConfig Parameter Services of cmdlet New-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Remove-AzDnsRecordConfig Parameter Flags of cmdlet Remove-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Remove-AzDnsRecordConfig Parameter Services of cmdlet Remove-AzDnsRecordConfig does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Dns. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Dns. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌PowerShell Core - Linux
❌PowerShell Core - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@WhiteHorseV WhiteHorseV changed the title Add NAPTR support and tests [Az.Dns] Add NAPTR support and tests Oct 8, 2024
@WhiteHorseV
Copy link
Author

I will update the test runs after the NAPTR feature is enabled in the PPE/Prod region.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant