Add breaking changes docs for breaking changes caused by v3 to v4 uprade #26248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
isra-fel
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Main comments:
- How about mutability?
- Every BC needs a section to explain to cx how to know if they are impacted by the BC. For example, in the array-list section, we should say "If you are using any of the
Arrayspecific properties or methods then you are impacted. For example, ... and ..."
Thanks
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
...g-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Yeming Liu <[email protected]>
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ade (#26248) * Add breaking changes docs for breaking changes caused by v3 to v4 upgrade * Apply suggestions from code review Co-authored-by: Yeming Liu <[email protected]> * Fixed a link issue and add explanation for enum change --------- Co-authored-by: Yeming Liu <[email protected]>
6 tasks
VeryEarly
added a commit
that referenced
this pull request
Oct 10, 2024
…ade (#26248) (#26264) * Add breaking changes docs for breaking changes caused by v3 to v4 upgrade * Apply suggestions from code review * Fixed a link issue and add explanation for enum change --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yeming Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.