Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elastic from generation to main #26340

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Migrate Elastic from generation to main #26340

merged 1 commit into from
Oct 18, 2024

Conversation

azure-pipelines[bot]
Copy link
Contributor

Description

Migrate Elastic from generation to main
The last commit of src/Elastic in generation is:
commit 4868827 Author: jkore1911 [email protected] Date: Tue Oct 15 12:45:01 2024 +0530 Liftr Elastic PS cmdlets for stable version 2024-03-01 (#26255) * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01 * Liftr Elastic PS cmdlets for stable version 2024-03-01

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 15, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Elastic
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzElasticMonitor Get-AzElasticMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticMonitor Get-AzElasticMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticOpenAi Get-AzElasticOpenAi Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticOpenAi Get-AzElasticOpenAi changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticTagRule Get-AzElasticTagRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticTagRule Get-AzElasticTagRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticVersion Get-AzElasticVersion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticVersion Get-AzElasticVersion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzElasticFilteringTagObject New-AzElasticFilteringTagObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzElasticMonitor Get-AzElasticMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticMonitor Get-AzElasticMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticOpenAi Get-AzElasticOpenAi Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticOpenAi Get-AzElasticOpenAi changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticTagRule Get-AzElasticTagRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticTagRule Get-AzElasticTagRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzElasticVersion Get-AzElasticVersion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzElasticVersion Get-AzElasticVersion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzElasticFilteringTagObject New-AzElasticFilteringTagObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzElasticOrganizationApiKey 1 1 Unassigned_Variable Get-AzElasticOrganizationApiKey -Body $EmailIdObject is a null-valued parameter value. -Body Assign value for $EmailIdObject.
⚠️ Get-AzElasticOrganizationApiKey 1 1 Unassigned_Variable Get-AzElasticOrganizationApiKey -Body $EmailIdObject is a null-valued parameter value. -Body Assign value for $EmailIdObject.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzElasticOrganizationApiKey 1 1 Unassigned_Variable Get-AzElasticOrganizationApiKey -Body $EmailIdObject is a null-valued parameter value. -Body Assign value for $EmailIdObject.
⚠️ Get-AzElasticOrganizationApiKey 1 1 Unassigned_Variable Get-AzElasticOrganizationApiKey -Body $EmailIdObject is a null-valued parameter value. -Body Assign value for $EmailIdObject.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Elastic. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Elastic. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 53.12 % 100.00% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 53.12% 100.00% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 53.12% 100.00% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 53.12% 100.00% Test coverage cannot be lower than the number of the last release.

Copy link
Contributor

Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon.

@Nickcandy
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor Author

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor Author

Azure Pipelines successfully started running 3 pipeline(s).

@Nickcandy
Copy link
Contributor

/azp run

Copy link
Contributor Author

Azure Pipelines successfully started running 3 pipeline(s).

@Nickcandy Nickcandy merged commit b0d8d60 into main Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants