Simplify the logic reading session-id by making it final #35822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
conniey
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ServiceBusSessionReceiveris constructed (only) by theSeviceBusSessionManager. WhenSeviceBusSessionManagerconstructsServiceBusSessionReceiver, the manager already knows the session's id with which the new receiver object will be associated. It means the receiver does not need to read the session-id via the (cached) Reactor chain each time someone asks; the sessionId can be a final String in the receiver.Note: If there is no session Id on the link upon link's activation, then the manager will never create the ServiceBusSessionReceiver, as the Mono, ServiceBusReceiveLink::getSessionId(), that is supposed to emit sessionId terminates to completion, it needs to emit a value for the manager to create receiver object.