Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Generate Admin code for 7.6-preview.1, add basic support #35425

Merged
merged 4 commits into from
May 9, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 30, 2024

Description

Part of #35252. This PR regenerates code for the new 7.6-preview.1 API version, wires up the version (without any new features) to the client, and updates metadata and tests. Future PRs will add support for new features.

Some tests were marked as live-only because of behavior changes that seemed to have been introduced by the latest test proxy version. An issue is open to track re-enabling playback testing: #35557.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Apr 30, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-administration

@mccoyp mccoyp changed the title [Key Vault] Generate code for 7.6-preview.1, add basic support [Key Vault] Generate Admin code for 7.6-preview.1, add basic support May 1, 2024
@mccoyp mccoyp force-pushed the kv-admin-7.6-preview.1-gen branch from ec3126d to 4dc7a32 Compare May 8, 2024 05:40
@mccoyp mccoyp force-pushed the kv-admin-7.6-preview.1-gen branch from 4dc7a32 to f34d844 Compare May 8, 2024 23:36
@mccoyp mccoyp marked this pull request as ready for review May 9, 2024 05:11
@mccoyp mccoyp merged commit a5b1671 into Azure:main May 9, 2024
17 checks passed
@mccoyp mccoyp deleted the kv-admin-7.6-preview.1-gen branch May 9, 2024 18:08
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 30, 2024
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Oct 9, 2024
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Oct 16, 2024
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants