[Y-Cable][Credo] Credo implementation of YCable class which inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons Signed-off-by: vaibhav-dahiya <[email protected]>
|
This pull request introduces 13 alerts when merging e7cb18a into 4533f82 - view on LGTM.com new alerts:
|
4 for Unused local variable
4 for Variable defined multiple times
2 for Unreachable code
1 for Testing equality to None
1 for Except block handles 'BaseException'
1 for Unused import
Signed-off-by: xinyu <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
|
This pull request introduces 12 alerts when merging 482da93 into 4533f82 - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <[email protected]>
|
This pull request introduces 1 alert when merging 1962fc2 into 4533f82 - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
…en change the prbs pattern Signed-off-by: xinyu <[email protected]>
|
This pull request introduces 1 alert when merging a3d976a into 4533f82 - view on LGTM.com new alerts:
|
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
|
This pull request introduces 1 alert when merging e2834d1 into 4533f82 - view on LGTM.com new alerts:
|
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
|
This pull request introduces 1 alert when merging 635dc4f into 4533f82 - view on LGTM.com new alerts:
|
Signed-off-by: xinyu <[email protected]>
vdahiya12
commented
Jul 12, 2021
| @@ -0,0 +1,13 @@ | |||
| mapping = { | |||
| "Credo": { | |||
There was a problem hiding this comment.
Can we please make the vendor name and model names in lower cases, to comply with fetching vendor mapping attribute.
example
mapping = {
"credo": {
"cacl2x321p2pa1ms": "credo.y_cable_credo"
}
}
There was a problem hiding this comment.
Yes, we can convert the PN and vendor name in lower case.
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
Signed-off-by: xinyu <[email protected]>
lguohan
previously approved these changes
Jul 26, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: xinyu <[email protected]>
lguohan
previously approved these changes
Aug 2, 2021
…not loaded Signed-off-by: xinyu <[email protected]>
lguohan
approved these changes
Aug 6, 2021
|
Hi @qiluo-msft , please cherry pick this to 202012, so that I can update the submodule. |
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 12, 2021
…from YCableBase required for Y-Cable API's in sonic-platform-daemons (#203) This PR adds support for YCable class required for platform-daemons to use the YCable API's for credo. Description Basically a vendor specific implementation of abstract YCableBase class . detailed design discussion can be found https:/Azure/SONiC/pull/757/files Motivation and Context Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called. How Has This Been Tested? Ran the changes on Arista7050cx3 switch, making changes inside the container. Co-authored-by: xinyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for YCable class required for platform-daemons to use the YCable API's for credo.
Description
Basically a vendor specific implementation of abstract YCableBase class .
detailed design discussion can be found https:/Azure/SONiC/pull/757/files
Motivation and Context
Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called.
How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.
Additional Information (Optional)
Signed-off-by: vaibhav-dahiya [email protected]