support-for-publicDNS-for-privateAKScluster : adding private_dns_zone_id & private_cluster_public_fqdn_enabled vars to control private aks cluster

[iamamitgera]

Fixes #000

Changes proposed in the pull request:

[ghost]

All CLA requirements met.

[stephane-pham-shift]

Hello,
I have the same requirement.
When can we change it?

[ghost]

Any news on when this will be merged?

[lonegunmanb]

Hi @liechtinat thanks for asking, for now this pr has a tiny format issue. I'd like to wait for @iamamitgera to fix that as he or she is the author, but if you're in a hurry maybe I can submit a new pr based on his to add this feature.

[ghost]

That would be cool, we currently have a fork of the repo to mitigate this issue as we want to use public resolvable kubeapi records for our private AKS clusters. I can also submit the PR if needed.

[iamamitgera]

I am regretful for delay as was occupied somewhere , I will get this done by tomorrow with requested changes

[the-technat]

Looks like terraform fmt was run. Anything that prevents this from merging?

[the-technat]

LGTM

[lonegunmanb]

Thanks @iamamitgera , almost LGTM but only two tiny description issues.

[the-technat]

@iamamitgera would you mind resolving the description issues?

[mkilchhofer]

@lonegunmanb can we merge this? We can file a PR to fix the quotation if needed but it looks kinda weird to wait on a contributor to fix quotes.

[lonegunmanb]

Thanks @iamamitgera , LGTM!

[mkilchhofer]

🥳 nice.
When do we have this released?