Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export addon_profile attributes #151

Merged
merged 4 commits into from
May 30, 2022

Conversation

davidkarlsen
Copy link
Contributor

Export the addon_profile attributes in order to make these consumable by other resources.

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb PTAL?

@lonegunmanb
Copy link
Member

Hi @davidkarlsen , thanks for your pr! I've just leave a comment on your code, would you please change a little to make the module caller easier to use this output? Thanks!

@davidkarlsen
Copy link
Contributor Author

Hi @davidkarlsen , thanks for your pr! I've just leave a comment on your code, would you please change a little to make the module caller easier to use this output? Thanks!

Sorry for the late response - didn't notice it. I can't see any comment? Maybe you forgot to submit the review?

outputs.tf Outdated Show resolved Hide resolved
@lonegunmanb
Copy link
Member

Hi @davidkarlsen , thanks for your pr! I've just leave a comment on your code, would you please change a little to make the module caller easier to use this output? Thanks!

Sorry for the late response - didn't notice it. I can't see any comment? Maybe you forgot to submit the review?

Hi @davidkarlsen , sorry for my fault. Would you please take a look?

Signed-off-by: David J. M. Karlsen <[email protected]>
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb fixed. Maybe needs some length check and defaulting to null?

@lonegunmanb
Copy link
Member

@lonegunmanb fixed. Maybe needs some length check and defaulting to null?

@davidkarlsen Great idea! Should we use try function?

@davidkarlsen
Copy link
Contributor Author

davidkarlsen commented May 20, 2022

@lonegunmanb fixed

can it be merged and released now?

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb what about #157 - can it be merged soon too? It's painful to lag so much on the provider version.

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb ping

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb ?

@lonegunmanb lonegunmanb merged commit 80cca3b into Azure:master May 30, 2022
@davidkarlsen davidkarlsen deleted the exportAddonAttibutes branch May 30, 2022 18:43
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb can you do a release too?

@lonegunmanb
Copy link
Member

@davidkarlsen #133 is nearly complete, can we wait for 1-2 days at most to see whether we can include this pr into our next release too? Thanks for your patience!

@lonegunmanb
Copy link
Member

@davidkarlsen 4.16.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants