Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CVEs #2929

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix CVEs #2929

merged 1 commit into from
Jul 15, 2024

Conversation

jennyf19
Copy link
Collaborator

No description provided.

@jennyf19 jennyf19 requested a review from a team as a code owner July 15, 2024 03:07
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

.NET 9 is simpler, that's nice.

@jennyf19 jennyf19 merged commit bf48d7a into master Jul 15, 2024
5 checks passed
@jennyf19 jennyf19 deleted the jennyf/fixCve branch July 15, 2024 17:02
kellyyangsong pushed a commit that referenced this pull request Jul 15, 2024
kellyyangsong added a commit that referenced this pull request Jul 15, 2024
* fix CVEs (#2929)

* resolve NU1107 errors

---------

Co-authored-by: jennyf19 <[email protected]>
<NetNineRuntimeVersion>9.0.0-preview.6.24327.7</NetNineRuntimeVersion>
<AspNetCoreNineRuntimeVersion>9.0.0-preview.6.24328.4</AspNetCoreNineRuntimeVersion>
<!--CVE-2024-30105-->
<SystemTextJsonVersion>8.0.4</SystemTextJsonVersion>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this should have been the fixed version of the oldest currently support .net version which is .NET 6. Then in .net 8 and higher specific fields set the higher versions.

With this going to pull in .NET 8 oriented libraries in .NET 6 targeted applicaitons

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not going to pull .NET 8 libraries in .NET 6 applications as the libraries have different target framework

@czb182
Copy link

czb182 commented Jul 22, 2024 via email

@jmprieur
Copy link
Collaborator

The .NET team recommends Microsoft.Extensions 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants