Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some backends do not implement the define pragma #266

Closed
5 tasks done
andreasabel opened this issue Nov 13, 2019 · 0 comments
Closed
5 tasks done

Some backends do not implement the define pragma #266

andreasabel opened this issue Nov 13, 2019 · 0 comments
Assignees
@andreasabel
Labels
C define Issue with define pragma enhancement Java/ANTLR
Milestone
2.8.4

Comments

@andreasabel
Copy link
Member

andreasabel commented Nov 13, 2019 •
edited
Loading

The C backend does not implement the define pragma.

EMinus. Exp  ::= Exp "-" Exp1;
EInt.   Exp1 ::= Integer;
eNeg.   Exp1 ::= "-" Exp1;

coercions Exp 1;

define eNeg e = EMinus (EInt 0) e;

For this example,

bnfc --c -m Foo.cf && make

fails at compilation of Printer.c, which treats eNeg as variant just as EInt and EMinus.

The backends Haskell, Java, CPP, OCaml do support define.

Backends that do not support define:

  • Haskell --functor
  • C
  • Java/ANTLR
  • C++ NoSTL: Skeleton.C does not compile
  • C++ with namespace
@andreasabel andreasabel mentioned this issue Nov 13, 2019
Open
@andreasabel andreasabel added the define Issue with define pragma label Jan 3, 2020
@andreasabel andreasabel changed the title C backend does not implement define pragma Some backends do not implement the define pragma Jan 3, 2020
@andreasabel andreasabel self-assigned this Jan 3, 2020
@andreasabel andreasabel added this to the 2.8.4 milestone Jan 3, 2020
@andreasabel andreasabel mentioned this issue Jan 3, 2020
Open
8 tasks
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 ] test case
f0ecff6
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 C++ ] refactor: removed clone of definedRules
bbe1f51
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 Haskell ] define needs qualification now (after #278)
7bbed91 
When translating `define`d constructors to Haskell, we need to refer to
the native AST constructors in a qualified way (after the changes
introduced in #278).
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 C++ namespace ] fixed by including define-defs in ns-block
07d3b9d
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 C++ NoSTL ] fixed Skeleton by filtering out defined rules
d239f23
andreasabel added a commit that referenced this issue Jan 3, 2020
@andreasabel
[ #266 Haskell --functor ] works for non-nested defines
8b68ea2 
If we refer to a defined constructor within another defined constructor,
the generated Haskell will still be incorrect.
andreasabel added a commit that referenced this issue Jan 4, 2020
@andreasabel
[ #266 define ] refactor Exp: constructor Var for parameters
43770b5
andreasabel added a commit that referenced this issue Jan 4, 2020
@andreasabel
[ #266 C ] fixed by adding a #define for a BNFC define to Absyn.h
2e60579
andreasabel added a commit that referenced this issue Jan 4, 2020
@andreasabel
[ #266 Java/ANTLR ] fixed by @members section with defined constructors
99078db
@andreasabel andreasabel mentioned this issue Jan 4, 2020
Closed
andreasabel added a commit that referenced this issue Jan 18, 2020
@andreasabel
[ Java ] Visitors: correct line breaks and new lines
6a51fde 
In particular, in the presence of defined constructors, there should not
be excessive new lines.  (Re #266)
@andreasabel andreasabel mentioned this issue Jan 27, 2020
Closed
@andreasabel andreasabel mentioned this issue Jan 31, 2021
Closed
3 tasks
andreasabel added a commit that referenced this issue Apr 1, 2021
@andreasabel
[ #266 ] expanded test case
ba485f6
andreasabel added a commit that referenced this issue Apr 1, 2021
@andreasabel
[ #266 ] Ocaml had problem with nested defined constructors
d9b4456 
The transation to Ocaml syntax was missing some parentheses.
andreasabel added a commit that referenced this issue Apr 2, 2021
@andreasabel
[ #266 ] C: removed errorneous defined constructors from Skeleton.c
be7cd0c
andreasabel added a commit that referenced this issue Apr 2, 2021
@andreasabel
[ #266 ] C: removed errorneous defined constructors from Skeleton.c
bb8049d
@andreasabel andreasabel mentioned this issue Apr 28, 2021
Closed
andreasabel added a commit that referenced this issue Dec 23, 2021
@andreasabel
Ocaml #266: sanitize bound variables in define
e3a472d 
Also: Disable hlint warnings connected to writing lambdas instead of functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
C define Issue with define pragma enhancement Java/ANTLR
Projects
None yet
Milestone
2.8.4
Development

No branches or pull requests
1 participant
@andreasabel